From 803f2cfdaddd77c0c6279f112981675d14dd23cd Mon Sep 17 00:00:00 2001 From: Tom Ryder Date: Fri, 20 Oct 2017 15:08:32 +1300 Subject: Remove unneeded exists..defined test series Better test coverage this way and neither `strict` nor `warnings` seems concerned about testing the definedness of a nonexistent key. --- lib/Mail/Run/Crypt.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/Mail/Run/Crypt.pm b/lib/Mail/Run/Crypt.pm index bd99043..2c33684 100644 --- a/lib/Mail/Run/Crypt.pm +++ b/lib/Mail/Run/Crypt.pm @@ -29,7 +29,7 @@ sub new { my $self = {%opts}; # We must have a recipient - exists $self->{mailto} and defined $self->{mailto} + defined $self->{mailto} or croak 'mailto required'; # Default the instance name to the package name if it wasn't given; @@ -42,9 +42,9 @@ sub new { # If signing, we need a key ID and a passphrase if ( $self->{sign} ) { - exists $self->{keyid} and defined $self->{keyid} + defined $self->{keyid} or croak 'keyid required for signing'; - exists $self->{passphrase} and defined $self->{passphrase} + defined $self->{passphrase} or croak 'passphrase required for signing'; } -- cgit v1.2.3