diff options
author | Tom Ryder <tom@sanctum.geek.nz> | 2017-11-06 09:51:09 +1300 |
---|---|---|
committer | Tom Ryder <tom@sanctum.geek.nz> | 2017-11-06 09:51:09 +1300 |
commit | 9927b230dd5ae7004f4d14ea9f684d06cd11a856 (patch) | |
tree | 89411d24bbfbd4058cb78b9e24cc177530659ced | |
parent | Don't overwrite plugin-specified user commands (diff) | |
download | dotfiles-9927b230dd5ae7004f4d14ea9f684d06cd11a856.tar.gz dotfiles-9927b230dd5ae7004f4d14ea9f684d06cd11a856.zip |
Don't use VimL ==# for number comparisons
The Google VimScript Guide says:
<https://google.github.io/styleguide/vimscriptfull.xml#Portability>
> Always use case-explicit operators for strings (=~# and =~?, never =~).
>
> This also applies to !~ == != > >= < and <=
> This only applies for strings. == and >= are fine for numbers, but ==#
> and >=# must be used for strings.
-rw-r--r-- | vim/autoload/detect_background.vim | 4 | ||||
-rw-r--r-- | vim/config/format.vim | 4 | ||||
-rw-r--r-- | vim/vimrc | 2 |
3 files changed, 5 insertions, 5 deletions
diff --git a/vim/autoload/detect_background.vim b/vim/autoload/detect_background.vim index 9758f8d3..c010dc53 100644 --- a/vim/autoload/detect_background.vim +++ b/vim/autoload/detect_background.vim @@ -28,8 +28,8 @@ function! detect_background#DetectBackground() abort " Choose the background setting based on this value if l:bg ==# 'default' - \ || l:bg ==# '7' - \ || l:bg ==# '15' + \ || l:bg == 7 + \ || l:bg == 15 return 'light' else return 'dark' diff --git a/vim/config/format.vim b/vim/config/format.vim index 54d46dc2..1f24ee56 100644 --- a/vim/config/format.vim +++ b/vim/config/format.vim @@ -5,7 +5,7 @@ if has('eval') " Figure out if we have the 'j' flag for 'formatoptions', to automatically " delete comment leaders when joining lines; keep it in a script variable let s:formatoptions_has_j = v:version > 703 - \ || v:version ==# 703 && has('patch541') + \ || v:version == 703 && has('patch541') " If we do have 'j', default to setting it if s:formatoptions_has_j @@ -38,7 +38,7 @@ if has('eval') " 'textwidth' wrapping to the current paragraph on every insertion or " deletion; keep in a script variable let s:formatoptions_has_a = v:version > 610 - \ || v:version ==# 610 && has('patch142') + \ || v:version == 610 && has('patch142') " 'a' needs testing if s:formatoptions_has_a @@ -16,7 +16,7 @@ if v:version >= 701 " The 'sahara' colorscheme only works for dark backgrounds with 256 colors if has('syntax') \ && &background ==# 'dark' - \ && (has('gui_running') || &t_Co ==# 256) + \ && (has('gui_running') || &t_Co == 256) silent! colorscheme sahara endif endif |