diff options
author | Tom Ryder <tom@sanctum.geek.nz> | 2018-12-17 15:33:37 +1300 |
---|---|---|
committer | Tom Ryder <tom@sanctum.geek.nz> | 2018-12-17 15:33:37 +1300 |
commit | 57d39d92fad5418e96dd4d69d6e86a578c3764b4 (patch) | |
tree | 66773bad1c693a02f393d4fe67f48cc20b69093e | |
parent | Follow ShellCheck's recommendation of -z over !-n (diff) | |
download | dotfiles-57d39d92fad5418e96dd4d69d6e86a578c3764b4.tar.gz dotfiles-57d39d92fad5418e96dd4d69d6e86a578c3764b4.zip |
Remove now-unneeded shellcheck disable rules
These two comments disabling SC2154 were added in commit 5fa3ef7,
because ShellCheck 0.50 did not recognise the NAME pointed to by `read
-a NAME` commands as an array assignment. This bug has been corrected in
ShellCheck 0.60, meaning that these comments are no longer required.
-rw-r--r-- | bash/bash_completion.d/make.bash | 1 | ||||
-rw-r--r-- | bash/bash_completion.d/path.bash | 1 |
2 files changed, 0 insertions, 2 deletions
diff --git a/bash/bash_completion.d/make.bash b/bash/bash_completion.d/make.bash index 909c52fb..b3148ff1 100644 --- a/bash/bash_completion.d/make.bash +++ b/bash/bash_completion.d/make.bash @@ -38,7 +38,6 @@ _make() { < <(printf '%s\n' "${line%%:*}") # Short-circuit if there are no targets - # shellcheck disable=SC2154 ((${#targets[@]})) || exit # Make matches behave correctly diff --git a/bash/bash_completion.d/path.bash b/bash/bash_completion.d/path.bash index c3bb7b80..9224506a 100644 --- a/bash/bash_completion.d/path.bash +++ b/bash/bash_completion.d/path.bash @@ -66,7 +66,6 @@ _path() { < <(printf '%s\0' "$PATH") # Print shell-quoted matching parts, null-terminated - # shellcheck disable=SC2154 for path in "${paths[@]}" ; do case $path in ("$2"*) printf '%q\0' "$path" ;; |