aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Ryder <tom@sanctum.geek.nz>2018-12-17 15:13:54 +1300
committerTom Ryder <tom@sanctum.geek.nz>2018-12-17 15:13:54 +1300
commit8ef8c5ec49d3722888d61084be2f06a9d8a17329 (patch)
tree683252cbfb7f333e11106534da8da4161997d570
parent7828d0f0ff2fc0fb3e2950b7093b7d6d7e62fb85 (diff)
downloaddotfiles-8ef8c5ec49d3722888d61084be2f06a9d8a17329.tar.gz
dotfiles-8ef8c5ec49d3722888d61084be2f06a9d8a17329.zip
Follow ShellCheck's recommendation of -z over !-n
I think !-n is a little clearer, but -z is OK.
-rw-r--r--sh/profile.d/welcome.sh2
-rw-r--r--sh/shrc.d/xd.sh2
2 files changed, 2 insertions, 2 deletions
diff --git a/sh/profile.d/welcome.sh b/sh/profile.d/welcome.sh
index cdd41edb..22cdde93 100644
--- a/sh/profile.d/welcome.sh
+++ b/sh/profile.d/welcome.sh
@@ -20,7 +20,7 @@ esac
# Show a fortune
if welcome fortune ; then
- if ! [ -n "$FORTUNE_PATH"] &&
+ if [ -z "$FORTUNE_PATH" ] &&
[ -d "$HOME"/.local/share/games/fortunes ] ; then
FORTUNE_PATH=$HOME/.local/share/games/fortunes
fi
diff --git a/sh/shrc.d/xd.sh b/sh/shrc.d/xd.sh
index 7c17adea..b26d88b3 100644
--- a/sh/shrc.d/xd.sh
+++ b/sh/shrc.d/xd.sh
@@ -8,7 +8,7 @@ xd() {
fi
# Complain if mark not actually set yet
- if ! [ -n "$PMD" ] ; then
+ if [ -z "$PMD" ] ; then
printf >&2 'gd(): Mark not set\n'
return 1
fi