diff options
| author | Tom Ryder <tom@sanctum.geek.nz> | 2016-07-15 00:34:48 +1200 |
|---|---|---|
| committer | Tom Ryder <tom@sanctum.geek.nz> | 2016-07-15 00:40:37 +1200 |
| commit | 8947c4c99f4c1ad92f23e59e84b224cf35e4ff81 (patch) | |
| tree | 70718ad01791f2ca67133376252cf69a693b14ea /bash/bashrc.d/vis.bash | |
| parent | Terser `read -rd ''` idiom (diff) | |
| download | dotfiles-8947c4c99f4c1ad92f23e59e84b224cf35e4ff81.tar.gz dotfiles-8947c4c99f4c1ad92f23e59e84b224cf35e4ff81.zip | |
Quote expansions within parameter expansions
I made the incorrect assumption that it was safe not to do this;
expansions that include glob characters, for example, can cause
problems.
Diffstat (limited to 'bash/bashrc.d/vis.bash')
| -rw-r--r-- | bash/bashrc.d/vis.bash | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/bash/bashrc.d/vis.bash b/bash/bashrc.d/vis.bash index 17c89ca8..f84cb702 100644 --- a/bash/bashrc.d/vis.bash +++ b/bash/bashrc.d/vis.bash @@ -2,14 +2,14 @@ # ~/.local/bin _vis() { local vispath - vispath=${VISPATH:-$HOME/.local/bin} + vispath=${VISPATH:-"$HOME"/.local/bin} [[ -d $vispath ]] || return while IFS= read -rd '' executable ; do COMPREPLY[${#COMPREPLY[@]}]=$executable done < <( shopt -s dotglob nullglob declare -a files - files=("${VISPATH:-$HOME/.local/bin}"/"${COMP_WORDS[COMP_CWORD]}"*) + files=("${VISPATH:-"$HOME"/.local/bin}"/"${COMP_WORDS[COMP_CWORD]}"*) declare -a executables for file in "${files[@]}" ; do [[ -f $file && -x $file ]] || continue |