aboutsummaryrefslogtreecommitdiff
path: root/sh
diff options
context:
space:
mode:
authorTom Ryder <tom@sanctum.geek.nz>2018-01-15 11:58:24 +1300
committerTom Ryder <tom@sanctum.geek.nz>2018-01-15 12:27:21 +1300
commit332c91bea2ffb35b6b39722a70c93c248fb64c30 (patch)
treea6ea421334ce073b2f4bf24633dcfd8ced0a5dc8 /sh
parent7503a23a550d1fb51998eccacf0c456efa5ae822 (diff)
downloaddotfiles-332c91bea2ffb35b6b39722a70c93c248fb64c30.tar.gz
Quote EDITOR/VISUAL assignments for clarity
This appeases ShellCheck 0.4.7, which is fretting that I meant a command expansion. I didn't, but it seems a bit nicer to quote these anyway. In sh/profile.d/editor.sh line 4: EDITOR=ed ^-- SC2209: Use var=$(command) to assign output (or quote to assign string). In sh/profile.d/editor.sh line 22: EDITOR=ex ^-- SC2209: Use var=$(command) to assign output (or quote to assign string). In sh/profile.d/visual.sh line 2: VISUAL=vi ^-- SC2209: Use var=$(command) to assign output (or quote to assign string).
Diffstat (limited to 'sh')
-rw-r--r--sh/profile.d/editor.sh6
-rw-r--r--sh/profile.d/visual.sh2
2 files changed, 4 insertions, 4 deletions
diff --git a/sh/profile.d/editor.sh b/sh/profile.d/editor.sh
index debb93b6..d8d13e0a 100644
--- a/sh/profile.d/editor.sh
+++ b/sh/profile.d/editor.sh
@@ -1,7 +1,7 @@
# Ideally, we'd use plain old ed(1), but many Linux distributions don't install
# it by default
if command -v ed >/dev/null 2>&1 ; then
- EDITOR=ed
+ EDITOR='ed'
# Failing that, if the system's implementation of ex(1) looks like Vim and we
# have exm(1df) in our $PATH, use the latter to work around Vim's ex mode
@@ -15,11 +15,11 @@ elif (
(*) exit 1 ;;
esac
) >/dev/null 2>&1 ; then
- EDITOR=exm
+ EDITOR='exm'
# Otherwise, we can just call ex(1) directly
else
- EDITOR=ex
+ EDITOR='ex'
fi
export EDITOR
diff --git a/sh/profile.d/visual.sh b/sh/profile.d/visual.sh
index 38ab9893..119d81c7 100644
--- a/sh/profile.d/visual.sh
+++ b/sh/profile.d/visual.sh
@@ -1,3 +1,3 @@
# Use first found implementation of vi(1)
-VISUAL=vi
+VISUAL='vi'
export VISUAL