From 8947c4c99f4c1ad92f23e59e84b224cf35e4ff81 Mon Sep 17 00:00:00 2001 From: Tom Ryder Date: Fri, 15 Jul 2016 00:34:48 +1200 Subject: Quote expansions within parameter expansions I made the incorrect assumption that it was safe not to do this; expansions that include glob characters, for example, can cause problems. --- bash/bashrc.d/keep.bash | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'bash/bashrc.d/keep.bash') diff --git a/bash/bashrc.d/keep.bash b/bash/bashrc.d/keep.bash index c7e42e04..585dd189 100644 --- a/bash/bashrc.d/keep.bash +++ b/bash/bashrc.d/keep.bash @@ -29,7 +29,7 @@ keep() { # Figure out the directory to which we're reading and writing these scripts local bashkeep - bashkeep=${BASHKEEP:-$HOME/.bashkeep.d} + bashkeep=${BASHKEEP:-"$HOME"/.bashkeep.d} mkdir -p -- "$bashkeep" || return # Parse options @@ -148,8 +148,8 @@ EOF complete -A function -A variable keep # Load any existing scripts in bashkeep -if [[ -d ${BASHKEEP:-$HOME/.bashkeep.d} ]] ; then - for bashkeep in "${BASHKEEP:-$HOME/.bashkeep.d}"/*.bash ; do +if [[ -d ${BASHKEEP:-"$HOME"/.bashkeep.d} ]] ; then + for bashkeep in "${BASHKEEP:-"$HOME"/.bashkeep.d}"/*.bash ; do [[ -e $bashkeep ]] || continue source "$bashkeep" done -- cgit v1.2.3