From 196155499c04b2c2050302e6575f1bcbbed052f1 Mon Sep 17 00:00:00 2001 From: Tom Ryder Date: Tue, 31 Oct 2017 20:28:49 +1300 Subject: Drastically simplify `lint` scripts Using find(1) to run the appropriate lint program over a set of files allows us to be terse and deal a little more dynamically with new files placed in the directories, but the downsides are that it's error-prone and that the order of testing is not predictable, and we'd ideally like the testing to be a little more deterministic than that. Case in point: writing the code for this commit unintentionally uncovered a longstanding issue where the URxvt Perl script `select.pl` was actually not being checked at all, due to an unneeded exclamation mark inverting the `-name` test for `*.pl` files. `select.pl` is presently not passing `perlcritic --brutal` on my machine, and likely has not been compliant since as early as commit 5000365 in March this year: >commit 500036564541ff2d65a7b2f6f6f556202d72d6ce >Author: Tom Ryder >Date: Fri Mar 24 11:01:05 2017 > > Lots of Makefile tidying > > ... > * Favour find(1) calls over shell loops > ... This commit also more clearly delineates between the language being "linted" and the target for which it's being linted. The latter is likely more desirable. This needs clarification. --- lint/urxvt.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'lint/urxvt.sh') diff --git a/lint/urxvt.sh b/lint/urxvt.sh index 507034be..7c7b1876 100644 --- a/lint/urxvt.sh +++ b/lint/urxvt.sh @@ -1 +1,2 @@ -find urxvt/ext -type f ! -name '*.pl' -print -exec perlcritic --brutal -- {} \; +perlcritic --brutal -- \ + urxvt/ext/*.pl -- cgit v1.2.3