From 8ef8c5ec49d3722888d61084be2f06a9d8a17329 Mon Sep 17 00:00:00 2001
From: Tom Ryder <tom@sanctum.geek.nz>
Date: Mon, 17 Dec 2018 15:13:54 +1300
Subject: Follow ShellCheck's recommendation of -z over !-n

I think !-n is a little clearer, but -z is OK.
---
 sh/profile.d/welcome.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'sh/profile.d')

diff --git a/sh/profile.d/welcome.sh b/sh/profile.d/welcome.sh
index cdd41edb..22cdde93 100644
--- a/sh/profile.d/welcome.sh
+++ b/sh/profile.d/welcome.sh
@@ -20,7 +20,7 @@ esac
 
     # Show a fortune
     if welcome fortune ; then
-        if ! [ -n "$FORTUNE_PATH"] &&
+        if [ -z "$FORTUNE_PATH" ] &&
             [ -d "$HOME"/.local/share/games/fortunes ] ; then
             FORTUNE_PATH=$HOME/.local/share/games/fortunes
         fi
-- 
cgit v1.2.3