From 8ef8c5ec49d3722888d61084be2f06a9d8a17329 Mon Sep 17 00:00:00 2001 From: Tom Ryder Date: Mon, 17 Dec 2018 15:13:54 +1300 Subject: Follow ShellCheck's recommendation of -z over !-n I think !-n is a little clearer, but -z is OK. --- sh/shrc.d/xd.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'sh/shrc.d/xd.sh') diff --git a/sh/shrc.d/xd.sh b/sh/shrc.d/xd.sh index 7c17adea..b26d88b3 100644 --- a/sh/shrc.d/xd.sh +++ b/sh/shrc.d/xd.sh @@ -8,7 +8,7 @@ xd() { fi # Complain if mark not actually set yet - if ! [ -n "$PMD" ] ; then + if [ -z "$PMD" ] ; then printf >&2 'gd(): Mark not set\n' return 1 fi -- cgit v1.2.3