From 8ef8c5ec49d3722888d61084be2f06a9d8a17329 Mon Sep 17 00:00:00 2001 From: Tom Ryder Date: Mon, 17 Dec 2018 15:13:54 +1300 Subject: Follow ShellCheck's recommendation of -z over !-n I think !-n is a little clearer, but -z is OK. --- sh/profile.d/welcome.sh | 2 +- sh/shrc.d/xd.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'sh') diff --git a/sh/profile.d/welcome.sh b/sh/profile.d/welcome.sh index cdd41edb..22cdde93 100644 --- a/sh/profile.d/welcome.sh +++ b/sh/profile.d/welcome.sh @@ -20,7 +20,7 @@ esac # Show a fortune if welcome fortune ; then - if ! [ -n "$FORTUNE_PATH"] && + if [ -z "$FORTUNE_PATH" ] && [ -d "$HOME"/.local/share/games/fortunes ] ; then FORTUNE_PATH=$HOME/.local/share/games/fortunes fi diff --git a/sh/shrc.d/xd.sh b/sh/shrc.d/xd.sh index 7c17adea..b26d88b3 100644 --- a/sh/shrc.d/xd.sh +++ b/sh/shrc.d/xd.sh @@ -8,7 +8,7 @@ xd() { fi # Complain if mark not actually set yet - if ! [ -n "$PMD" ] ; then + if [ -z "$PMD" ] ; then printf >&2 'gd(): Mark not set\n' return 1 fi -- cgit v1.2.3