From e6bfb8f7065ded88ebc1af4dec865a715f33f03f Mon Sep 17 00:00:00 2001
From: Tom Ryder <tom@sanctum.geek.nz>
Date: Fri, 3 Nov 2017 22:55:39 +1300
Subject: Use direct :write !cmd instead of shellescape()

This is a much better method of calling external programs on the
buffer's contents, not just because it avoids the mess of :execute
evaluation but also because it doesn't require that there actually be a
filename for the current buffer.

This drastically simplifies the HTML tidy(1) call in particular.
---
 vim/ftplugin/html.vim |  7 +------
 vim/ftplugin/perl.vim | 17 ++++++-----------
 2 files changed, 7 insertions(+), 17 deletions(-)

(limited to 'vim/ftplugin')

diff --git a/vim/ftplugin/html.vim b/vim/ftplugin/html.vim
index d705bd71..4d3991f3 100644
--- a/vim/ftplugin/html.vim
+++ b/vim/ftplugin/html.vim
@@ -1,10 +1,5 @@
 " Run tidy -eq -utf8 on file for the current buffer
-if exists('*shellescape')
-  function s:HTMLTidy()
-    execute '!tidy -eq -utf8 ' . shellescape(expand('%'))
-  endfunction
-  nnoremap <LocalLeader>v :execute :<C-U>call <SID>HTMLTidy()<CR>
-endif
+nnoremap <LocalLeader>v :write !tidy -eq -utf8<CR>
 
 " Make a bare URL into a link to itself
 function! s:UrlLink()
diff --git a/vim/ftplugin/perl.vim b/vim/ftplugin/perl.vim
index 310ffe7e..eeed2bb7 100644
--- a/vim/ftplugin/perl.vim
+++ b/vim/ftplugin/perl.vim
@@ -1,11 +1,6 @@
-" External commands for Perl files
-if exists('*shellescape')
-
-  " Run perl -c on file for the current buffer
-  nnoremap <LocalLeader>pc :execute "!perl -c " . shellescape(expand("%"))<CR>
-  " Run perlcritic on the file for the current buffer
-  nnoremap <LocalLeader>pl :execute "!perlcritic " . shellescape(expand("%"))<CR>
-  " Run the current buffer through perltidy
-  nnoremap <LocalLeader>pt :%!perltidy<CR>
-
-endif
+" Run perl -c on file for the current buffer
+nnoremap <LocalLeader>pc :write !perl -c<CR>
+" Run perlcritic on the file for the current buffer
+nnoremap <LocalLeader>pl :write !perlcritic<CR>
+" Run the current buffer through perltidy
+nnoremap <LocalLeader>pt :%!perltidy<CR>
-- 
cgit v1.2.3