From fceb0bb7445bcb86993354e6765ee7fa0943ca42 Mon Sep 17 00:00:00 2001 From: Tom Ryder Date: Fri, 10 Jun 2016 02:13:02 +1200 Subject: Fix a couple Perl::Critic whines Still not completely clean yet --- bin/irc-ebooks-feed | 10 +++++----- bin/irc-ebooks-test | 5 +++-- 2 files changed, 8 insertions(+), 7 deletions(-) (limited to 'bin') diff --git a/bin/irc-ebooks-feed b/bin/irc-ebooks-feed index 9b1011d..8cf9214 100755 --- a/bin/irc-ebooks-feed +++ b/bin/irc-ebooks-feed @@ -46,15 +46,15 @@ const my $LINE_FORMAT => qr{ # Skip text lines that match these patterns const my @SKIP_PATTERNS => ( - qr{ <[@%+ ]?\w+> }msx, # Looks like nick (probably a quote) - qr{ \d:\d }msx, # Looks like timestamp (probably a quote) - qr{ :// }msx, # Looks like URL + qr{ <[@%+ ]?\w+> }msx, # Looks like nick (probably a quote) + qr{ \d:\d }msx, # Looks like timestamp (probably a quote) + qr{ :// }msx, # Looks like URL ); # Delete these from text const my @DELETE_PATTERNS => ( - qr{ ^\w+:\s }msx, # Address in form of "nick: " - qr{ ["()\[\]] }msx, # Punctuations marks that may unbalance + qr{ ^\w+:\s }msx, # Address in form of "nick: " + qr{ ["()\[\]] }msx, # Punctuations marks that may unbalance ); # Import required modules diff --git a/bin/irc-ebooks-test b/bin/irc-ebooks-test index 46fb45c..d7e161e 100755 --- a/bin/irc-ebooks-test +++ b/bin/irc-ebooks-test @@ -57,7 +57,8 @@ my $irc_ebooks = IRC::Ebooks->new($config) or croak q{Failed to create IRC::Ebooks object}; # Have him respond to each line of standard input -while (<>) { +while (my $response = <>) { chomp; - say $irc_ebooks->reply($_); + say $irc_ebooks->reply($response) + or carp q{Failed to write to stdout}; } -- cgit v1.2.3